Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing_formula: fix cask installation advice on tap migration #10218

Merged
merged 1 commit into from Jan 4, 2021
Merged

missing_formula: fix cask installation advice on tap migration #10218

merged 1 commit into from Jan 4, 2021

Conversation

andreastt
Copy link
Contributor

When an installed formula is missing and its source has migrated
to a new tap, Homebrew warns the user about this, saying:

You can access it again by running:
  brew tap new-name
And then you can install it by running:
  brew cask install new-name

Unfortunately, the "brew cask install" incantation is deprecated
and the advice won't work:

Error: Calling brew cask install is disabled! Use brew install [--cask] instead.

This alters the advice to use the new "brew install --cask" notation,
fixing the advice presented to the user.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

When an installed formula is missing and its source has migrated
to a new tap, Homebrew warns the user about this, saying:

	You can access it again by running:
	  brew tap new-name
	And then you can install it by running:
	  brew cask install new-name

Unfortunately, the "brew cask install" incantation is deprecated
and the advice won't work:

	Error: Calling brew cask install is disabled! Use brew install [--cask] instead.

This alters the advice to use the new "brew install --cask" notation,
fixing the advice presented to the user.
@jonchang
Copy link
Contributor

jonchang commented Jan 4, 2021

Thanks!

@jonchang jonchang merged commit fe01a9f into Homebrew:master Jan 4, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 4, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants